Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker compose file to the root of the project #571

Merged
merged 5 commits into from
Aug 8, 2024
Merged

Add docker compose file to the root of the project #571

merged 5 commits into from
Aug 8, 2024

Conversation

haseebzaki-07
Copy link
Contributor

Pull Request

Title

This pr adds docker-compose.yaml at the root of the project

Description

fixes #564

Checklist

  • [x ] I have tested the changes locally
  • [x ] Documentation has been updated (if necessary)
  • Changes are backward-compatible

Footer

@vercel Vercel
Copy link

vercel bot commented Aug 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 9:56am

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@VaibhavArora314
Copy link
Owner

Where are the dockerfiles? I think it will not work without dockerfiles if I am not wrong.

@haseebzaki-07
Copy link
Contributor Author

I have created a separate issue for the Dockerfile(s) issue #690. I can write the Dockerfiles(s) there.

@haseebzaki-07
Copy link
Contributor Author

I have added the Dockerfiles

VaibhavArora314
VaibhavArora314 reviewed Aug 8, 2024
View reviewed changes
Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one change. Instead of passing the .env file to the backend container, only pass the database url of the mongodb container. As for the rest of the environment variables, I will add default values.

@haseebzaki-07
Copy link
Contributor Author

Sure I'll do that

@haseebzaki-07
Copy link
Contributor Author

I have updated the docker compose having only the DATABASE_URL as the env-variable

akbatra567
akbatra567 requested changes Aug 8, 2024
View reviewed changes
docker-compose.yml Outdated
@@ -0,0 +1,40 @@
version: '3.8'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: '3.8'

Remove version field as in latest update docker has made it obsolete, removing the line fixes the issue, link for reference: https://forums.docker.com/t/docker-compose-yml-version-is-obsolete/141313

@akbatra567 akbatra567 merged commit e773f81 into VaibhavArora314:main Aug 8, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaibhavArora314 VaibhavArora314 VaibhavArora314 approved these changes

@akbatra567 akbatra567 akbatra567 approved these changes

Assignees

@haseebzaki-07 haseebzaki-07

Labels
gssoc GSSOC level2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Integrating docker compose into the project
3 participants
@haseebzaki-07 @VaibhavArora314 @akbatra567